From b74cd58352ab0f8783048d9f035989ad4bc4067f Mon Sep 17 00:00:00 2001
From: lantua <16190491+lantua@users.noreply.github.com>
Date: Sat, 17 Aug 2024 20:46:27 -0400
Subject: [PATCH] Fix types

---
 libs/gi/formula/src/calculator.ts  | 2 +-
 libs/gi/formula/src/formulaText.ts | 9 +++++----
 libs/sr/formula/src/calculator.ts  | 2 +-
 libs/sr/formula/src/formulaText.ts | 7 ++-----
 4 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/libs/gi/formula/src/calculator.ts b/libs/gi/formula/src/calculator.ts
index e81ba2bbad..279958436b 100644
--- a/libs/gi/formula/src/calculator.ts
+++ b/libs/gi/formula/src/calculator.ts
@@ -15,7 +15,7 @@ type MemRec<V> = Partial<Record<Member, V>>
 type CondInfo = MemRec<MemRec<Partial<Record<Sheet, Record<string, number>>>>>
 
 export type CalcMeta = PartialMeta & Info & { [reusable]?: true }
-type PartialMeta = {
+export type PartialMeta = {
   tag?: Tag
   op: 'const' | 'sum' | 'prod' | 'min' | 'max' | 'sumfrac' | 'res'
   ops: CalcResult<number, PartialMeta>[]
diff --git a/libs/gi/formula/src/formulaText.ts b/libs/gi/formula/src/formulaText.ts
index 3c5f5ff67d..fc2884caee 100644
--- a/libs/gi/formula/src/formulaText.ts
+++ b/libs/gi/formula/src/formulaText.ts
@@ -1,6 +1,7 @@
 import type { CalcResult } from '@genshin-optimizer/pando/engine'
-import type { CalcMeta } from './calculator'
+import type { PartialMeta } from './calculator'
 
+type Output = PartialMeta
 type FormulaText = {
   name: string | undefined
   formula: string
@@ -10,8 +11,8 @@ type FormulaText = {
   deps: FormulaText[]
 }
 export function translate(
-  data: CalcResult<number, CalcMeta>,
-  cache: Map<CalcResult<number, CalcMeta>, FormulaText> = new Map()
+  data: CalcResult<number, Output>,
+  cache: Map<CalcResult<number, Output>, FormulaText> = new Map()
 ): FormulaText {
   const old = cache.get(data)
   if (old) return old
@@ -22,7 +23,7 @@ export function translate(
 
   const deps = new Set<FormulaText>()
   function getString(
-    ops: CalcResult<number, CalcMeta>[],
+    ops: CalcResult<number, Output>[],
     prec: number // precedence of the encompassing/parent term
   ): string[] {
     return ops.map((op) => {
diff --git a/libs/sr/formula/src/calculator.ts b/libs/sr/formula/src/calculator.ts
index e81ba2bbad..279958436b 100644
--- a/libs/sr/formula/src/calculator.ts
+++ b/libs/sr/formula/src/calculator.ts
@@ -15,7 +15,7 @@ type MemRec<V> = Partial<Record<Member, V>>
 type CondInfo = MemRec<MemRec<Partial<Record<Sheet, Record<string, number>>>>>
 
 export type CalcMeta = PartialMeta & Info & { [reusable]?: true }
-type PartialMeta = {
+export type PartialMeta = {
   tag?: Tag
   op: 'const' | 'sum' | 'prod' | 'min' | 'max' | 'sumfrac' | 'res'
   ops: CalcResult<number, PartialMeta>[]
diff --git a/libs/sr/formula/src/formulaText.ts b/libs/sr/formula/src/formulaText.ts
index 38ba240bef..ec723af896 100644
--- a/libs/sr/formula/src/formulaText.ts
+++ b/libs/sr/formula/src/formulaText.ts
@@ -1,11 +1,8 @@
 import type { CalcResult } from '@genshin-optimizer/pando/engine'
 import type { Tag } from './data/util'
+import type { PartialMeta } from './calculator'
 
-type Output = {
-  tag: Tag | undefined
-  op: 'const' | 'sum' | 'prod' | 'min' | 'max' | 'sumfrac'
-  ops: CalcResult<number, Output>[]
-}
+type Output = PartialMeta
 
 type FormulaText = {
   name: string | undefined