-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React 15.x #44
Comments
See frig-js/frig#128 for Frig work |
null select example issue
|
For the "null select example" issue: Tried changing this in Frig's value_linked_select.js: - if (el.value === '') return null
+ if (el.value === '') return '' Now, if I select the null value "Things" (see kitchen-sink.jsx excerpt below), it won't stay selected, it snaps back to "Stuff": <Input
name="select_null_value_example"
options={[
{ label: 'Stuff', value: null },
[null, 'Things'],
'why not both?',
]}
/> If I leave the code alone, it works (keeps "Things" selected) but React will warn. |
inputs switching between controlled/uncontrolled
edit: Fixed in frig-js/frig@4e9d132 |
clearing/blanking input event issueAnother issue, this one needs to be seen to be believed:
edit: Fixed in frig-js/frig@144e746 |
Fixes the following warning: ``` Warning: FriggingBootstrap.Input is changing a uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. ``` frig-js/frigging-bootstrap#44 (comment)
See frig-js/frigging-bootstrap#44 (comment) for more info Basically, if onChange had to handle a SyntheticEvent where e.target.value is null, we would use the SyntheticEvent incorrectly as the actual value
Frig/Frigging Bootstrap currently works okay on React 15.0.x but there are several deprecations/warnings:
valueLink deprecation
valueLink
prop oninput
is deprecated; setvalue
andonChange
insteadvalueLink
prop onselect
is deprecated; setvalue
andonChange
insteadvalueLink
prop ontextarea
is deprecated; setvalue
andonChange
insteadnumeric string values for CSS properties
div
tag (owner:FriggingBootstrap.Switch
) was passed a numeric string value for CSS propertymarginLeft
(value:0
) which will be treated as a unitless number in a future version of React.color picker
n.b. These propTypes errors are probably unrelated to the upgrade
startDragging
of typefunction
supplied toHueSlider
, expectedboolean
. Check the render method ofDraggable
.startDragging
of typefunction
supplied toColorMap
, expectedboolean
. Check the render method ofDraggable
.The text was updated successfully, but these errors were encountered: