DataPackage.json Creator error - licenses not working

[mchelen]

The tool at http://data.okfn.org/tools/create is not letting me select a license, the dropdown is blank and greyed out.

[rufuspollock]

Good point. My guess is that we need to implement that properly and it isn't yet ...

The relevant repo to work on is https://github.com/okfn/datapackage-init - see the demo directory

[sxren]

@rgrp Oops. Just noticed the comment you added to #142 about this issue. Would you like me to attach the pull request at issue #144 to this issue or...? I'll search next time. Sorry about that.

[rufuspollock]

@sxren don't worry - good to have the patch. I think your solution fixes this issue (not the other one). However note the comments there about how we probably want to improve this more medium-term (i.e. patch upstream in datapackage-init ...).

[rufuspollock]

@sxren asked:

The Licenses select field options at tools/create should run off https://github.com/okfn/licenses.

@rgrp from the http://licenses.opendefinition.org api? or directly from github? thanks!

[rufuspollock]

@sxren right now I think we should just pull a very short list of potential licenses from that repo and use it for that field with their IDs and if folks don't use that we give them option to add a name + url (cf the data package spec and definition of licenses field).

[sxren]

@rgrp

1. the issue involves three projects: https://github.com/okfn/licenses, https://github.com/okfn/datapackage-init, and this one
2. Merge Clipol.org data into this repo okfn/licenses#31 (comment) proposes rewriting https://github.com/okfn/licenses as a node module—if we want more than a quick fix, this seems like the place to start; what do you think?
3. if https://github.com/okfn/licenses is a node modue, should that be a different project? or would you prefer everything (data and static github pages api) in one place?
4. https://github.com/okfn/data.okfn.org/blob/master/views/tools/dp/create.html is essentially a duplicate of the https://github.com/okfn/datapackage-init demo app, minus the broken licenses field. i'm not well versed in node + express; could that demo app be used as the tools/create page in this project? if so, what would be the cons of doing that?
5. given the above, a quick fix here makes sense because broken and volunteer time, not so much. options:
   1. remove the licenses select field
   2. fix the licenses select field
      • proposed short list: ODC-PDDL-1.0, ODC-BY-1.0, Other
      • ODC-PDDL-1.0 vs PDDL-1.0—are both correct? which is preferred?

thank you.

[rufuspollock]

@sxren I agree on quick-fix (ultimately okfn/licenses should become simple enough to submodule or similar but let's leave that for now).

• Your basic list plus ODC-ODbL + CC-Zero, CC-By-4.0 and CC-By-SA-4.0 looks good
• We just need name, url and id for our work

This page https://github.com/okfn/data.okfn.org/blob/master/views/tools/dp/create.html does indeed directly reuse the demo app. If we fix the demo app then it will be very simple to deploy to the create page so let's start there.

[sxren]

@rgrp

• clarification: instead of sourcing app.js and bundle.js into the tools/create view from the labs website, could the tools/create route run the demo app, view and all? app within app. no deploy to labs required to update tools/create. one less page to maintain. or is that a not a thing in express?
• ODC-PDDL-1.0 vs PDDL-1.0—which is preferred? or am i being overly conscious of an unimportant detail?

thanks.

[rufuspollock]

@sxren maybe but I'm not sure of exact way to do that plus I want the demo app in datapackage-init as an example for others not just our use.

Re identifiers for licenses we should use those in github.com/okfn/licenses

[sxren]

@rgrp have a look at the pull request to datapackage-init and let me know what you think. suggestions always welcome. thank you.

hold off on the review. a github api request per page view is a bad idea. also, the licenses var in the lib isn't available to the view via the sourced javascript. i'll have a look at it again at lunch or tonight.

[sxren]

@rgrp importing https://github.com/sxren/datapackage-licenses into both datapackage-init and data.okfn.org, along with my original fix to data.okfn.org and a small variation on my changes to datapackage-init would wrap up the license issue in both projects. i don't see a place to stick the same information in datapackage-init where the data would also be accessible to nunjucks. i gave you access to https://github.com/sxren/datapackage-licenses in case you're ok with this approach and want to move it to okfn. open to suggestions as always.

[rufuspollock]

@sxren I don't mind doing the simplest thing possible - so whatever works for you. I do note your PR on the datapackage-init looked pretty good openknowledge-archive/datapackage-init-js#5 - that's the way I'd e going and then reusing / copying over to data.okfn.org (I know it is a bit round about but it is definitely cleaner way to go and allows others to reuse demo code in other projects - which is important).

[rufuspollock]

FIXED. http://data.okfn.org/tools/create (fixed last weekend).