Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be lenient in audio metadata we accept #168

Open
sentry-io bot opened this issue May 24, 2023 · 0 comments
Open

Be lenient in audio metadata we accept #168

sentry-io bot opened this issue May 24, 2023 · 0 comments

Comments

@sentry-io
Copy link

sentry-io bot commented May 24, 2023

We do some fun stuff in the set_mp3_meta_data function to make the file better, but in doing so, we make our code fragile. If small pieces of data are missing, we crash and fail to make an mp3. For example, the error below is because we don't have the date argued.

Sentry Issue: DOCTOR-V

KeyError: 'date_argued'
  File "doctor/views.py", line 353, in convert_audio
    set_mp3_meta_data(audio_data, filepath)
  File "doctor/tasks.py", line 496, in set_mp3_meta_data
    date_argued = audio_data["date_argued"]

Lame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants