Add "_bucket" suffix to histogram Samples #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed by this PR:
According to the upstream documentation here - bucket counts should take the form _bucket{le="..."}. However, the current code does not add the "_bucket" suffix.
Background:
I discovered this trying to have DataDog import the bucket values. OpenMetrics Histograms were not being processed correctly by DataDog after verifying that I had setup the agent correctly. DataDog was capturing the _count and _sum values but not the buckets. Once I made the change in this PR, the agent started loading the histograms properly.