Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bench restart downtimes #1335

Closed
ankush opened this issue Jan 10, 2024 · 1 comment
Closed

Reduce bench restart downtimes #1335

ankush opened this issue Jan 10, 2024 · 1 comment

Comments

@ankush
Copy link
Member

ankush commented Jan 10, 2024

  • Restart web process first - max 30 seconds downtime if ongoing request
  • Restart remaining process later (background worker and whatever else we have in supervisor conf)

https://github.com/frappe/agent/blob/e6176a3da370c9cfce7fd49e9ef4a38aaf12ab62/agent/bench.py#L551-L554

Refer bench PR for reference: frappe/bench#1507

@ankush
Copy link
Member Author

ankush commented Feb 21, 2024

supervisor update seems to be doing it in groups only, no need to change anything.

image

@ankush ankush closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant