Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning message on bench update #1991

Open
FHenry opened this issue Sep 21, 2024 · 3 comments · May be fixed by #2091
Open

Warning message on bench update #1991

FHenry opened this issue Sep 21, 2024 · 3 comments · May be fixed by #2091
Labels
bug Something isn't working

Comments

@FHenry
Copy link

FHenry commented Sep 21, 2024

Information about bug

During bench udpate there is this warning

Installing helpdesk
$ /workspace/development/frappe-bench/env/bin/python -m pip install --quiet --upgrade -e /workspace/development/frappe-bench/apps/helpdesk 
  DEPRECATION: Legacy editable install of helpdesk==0.10.0 from file:///workspace/development/frappe-bench/apps/helpdesk (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457

possible fix is to migrate to pyproject.toml new standard

Are you interested in a PR that do that ?

Version

Frappe Version (version-15 branch)

Installation method

docker

Relevant log output / Stack trace / Full Error Message.

No response
@FHenry FHenry added the bug Something isn't working label Sep 21, 2024
@FHenry FHenry changed the title Warning message on `bench update Warning message on bench update Sep 21, 2024
@RitvikSardana
Copy link
Member

Yes @FHenry
you may create a PR for the same.

Would review and merge if everything seems correct

@FHenry FHenry linked a pull request Dec 16, 2024 that will close this issue
Open
@FHenry
Copy link
Author

FHenry commented Dec 16, 2024

@RitvikSardana I let you check and review the PR
the pyproject.toml was inspired from https://github.com/frappe/erpnext/blob/develop/pyproject.toml

@FHenry
Copy link
Author

FHenry commented Jan 22, 2025

@RitvikSardana
Hi, I've just pulled develop branch in the PR #2091
I've seens that you've also create draft PR #2109

Can I do something to help the merge of this technical only topic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use PEP 660 python install method pyproject.toml FHenry/helpdesk
2 participants
@FHenry @RitvikSardana