From cd7c85e9a9f2fa5bd80c135d8b4b8092aa863c09 Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 28 Nov 2024 11:50:26 +0530
Subject: [PATCH 1/2] fix: create communication if description is available

---
 helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py b/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
index daf302688..89e79aca6 100644
--- a/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
+++ b/helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
@@ -157,7 +157,7 @@ def by_priority(query: Query, direction: Order):
         }
 
     def publish_update(self):
-        publish_event("helpdesk:ticket-update", {"name": self.name})
+        publish_event("helpdesk:ticket-update", self.name)
         capture_event("ticket_updated")
 
     def autoname(self):
@@ -192,6 +192,9 @@ def after_insert(self):
         capture_event("ticket_created")
         publish_event("helpdesk:new-ticket", {"name": self.name})
 
+        if self.get("description"):
+            self.create_communication_via_contact(self.description)
+
     def on_update(self):
         # flake8: noqa
         if self.status == "Open":

From f3097b70913d9ed2ac1100572d11e60f337f137a Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Thu, 28 Nov 2024 11:51:52 +0530
Subject: [PATCH 2/2] fix: sockets in ticket view and list view

---
 desk/src/pages/TicketAgent.vue    | 10 +++++++++-
 desk/src/pages/TicketCustomer.vue | 17 ++++++++++++++++-
 desk/src/pages/Tickets.vue        | 11 ++++++++++-
 3 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/desk/src/pages/TicketAgent.vue b/desk/src/pages/TicketAgent.vue
index a40d9b1a0..c207ed9ed 100644
--- a/desk/src/pages/TicketAgent.vue
+++ b/desk/src/pages/TicketAgent.vue
@@ -46,7 +46,7 @@
     <div v-if="ticket.data" class="flex h-screen overflow-hidden">
       <div class="flex flex-1 flex-col">
         <!-- ticket activities -->
-        <div class="overflow-y-auto flex-1">
+        <div class="overflow-hidden flex-1">
           <Tabs v-model="tabIndex" v-slot="{ tab }" :tabs="tabs" class="h-full">
             <TicketAgentActivities
               ref="ticketAgentActivitiesRef"
@@ -156,6 +156,7 @@ import {
   ActivityIcon,
   EmailIcon,
 } from "@/components/icons";
+import { socket } from "@/socket";
 import { useTicketStatusStore } from "@/stores/ticketStatus";
 import { useUserStore } from "@/stores/user";
 import { createToast, setupCustomActions } from "@/utils";
@@ -376,11 +377,18 @@ function updateTicket(fieldname: string, value: string) {
     },
   });
 }
+
 onMounted(() => {
   document.title = props.ticketId;
+  socket.on("helpdesk:ticket-update", (ticketID) => {
+    if (ticketID === Number(props.ticketId)) {
+      ticket.reload();
+    }
+  });
 });
 
 onUnmounted(() => {
   document.title = "Helpdesk";
+  socket.off("helpdesk:ticket-update");
 });
 </script>
diff --git a/desk/src/pages/TicketCustomer.vue b/desk/src/pages/TicketCustomer.vue
index e61d96cac..8980ddbc1 100644
--- a/desk/src/pages/TicketCustomer.vue
+++ b/desk/src/pages/TicketCustomer.vue
@@ -56,7 +56,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, provide, ref } from "vue";
+import { computed, onMounted, onUnmounted, provide, ref } from "vue";
 import { createResource, Button, Breadcrumbs } from "frappe-ui";
 import { Icon } from "@iconify/vue";
 import { useError } from "@/composables/error";
@@ -67,6 +67,7 @@ import TicketTextEditor from "./ticket/TicketTextEditor.vue";
 import { ITicket } from "./ticket/symbols";
 import { useRouter } from "vue-router";
 import { createToast } from "@/utils";
+import { socket } from "@/socket";
 import { LayoutHeader } from "@/components";
 import TicketCustomerSidebar from "@/components/ticket/TicketCustomerSidebar.vue";
 import { useScreenSize } from "@/composables/screen";
@@ -181,4 +182,18 @@ const showFeedback = computed(() => {
   );
   return hasAgentCommunication && isFeedbackMandatory;
 });
+
+onMounted(() => {
+  document.title = props.ticketId;
+  socket.on("helpdesk:ticket-update", (ticketID) => {
+    if (ticketID === Number(props.ticketId)) {
+      ticket.reload();
+    }
+  });
+});
+
+onUnmounted(() => {
+  document.title = "Helpdesk";
+  socket.off("helpdesk:ticket-update");
+});
 </script>
diff --git a/desk/src/pages/Tickets.vue b/desk/src/pages/Tickets.vue
index eca75fcec..410be5d8f 100644
--- a/desk/src/pages/Tickets.vue
+++ b/desk/src/pages/Tickets.vue
@@ -50,13 +50,14 @@
 </template>
 
 <script setup lang="ts">
-import { ref, computed } from "vue";
+import { ref, computed, onMounted, onUnmounted } from "vue";
 import { useStorage } from "@vueuse/core";
 import { createResource, Breadcrumbs } from "frappe-ui";
 import { TicketsAgentList } from "@/components/ticket";
 import { ViewControls, LayoutHeader } from "@/components";
 import { useUserStore } from "@/stores/user";
 import { useRoute } from "vue-router";
+import { socket } from "@/socket";
 const { getUser } = useUserStore();
 
 const route = useRoute();
@@ -360,4 +361,12 @@ const sortableFields = createResource({
     show_customer_portal_fields: isCustomerPortal,
   },
 });
+
+onMounted(() => {
+  socket.on("helpdesk:new-ticket", () => tickets.reload());
+});
+
+onUnmounted(() => {
+  socket.off("helpdesk:new-ticket");
+});
 </script>