Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RollbackSynchronizer ack's to itself on mixed authority #373

Closed
elementbound opened this issue Jan 6, 2025 · 0 comments · Fixed by #378
Closed

RollbackSynchronizer ack's to itself on mixed authority #373

elementbound opened this issue Jan 6, 2025 · 0 comments · Fixed by #378
Labels
bug Something isn't working

Comments

@elementbound
Copy link
Contributor

🐛 Description

RollbackSynchronizer can end up sending full state ack's to the local peer. Example node tree:

Player (1)
├── Input (2)
├── Preview (2)
└── RollbackSynchronizer (1)

The parentheses mark ownership. In this case, on peer 1, RollbackSynchronizer will receive Preview's full state from peer 2. Then, the ack will be sent to the RollbackSynchronizer's owner, 1.

This results in an error, as the "call_remote" RPC will be called on the local peer.

To fix, the ack should be sent to the sender ( who sent the state itself ), instead of the RollbackSynchronizer's owner.

Versions

  • Godot version: v4.3.stable.custom_build [f491b2a5d]
  • netfox version: 1.14.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant