Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic properties #17

Open
pepijnblom opened this issue May 16, 2024 · 3 comments
Open

Fix dynamic properties #17

pepijnblom opened this issue May 16, 2024 · 3 comments

Comments

@pepijnblom
Copy link

The module is currently breaking 2.4.6 with php 8.2 due to dynamic properties, here's a patch

Subject: [PATCH] fix dynamic properties of belco
---
Index: app/code/Belco/Widget/Helper/Data.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/code/Belco/Widget/Helper/Data.php b/app/code/Belco/Widget/Helper/Data.php
--- a/app/code/Belco/Widget/Helper/Data.php	(revision 3c846603dbec5d956d2665105b2d29fb8b5126aa)
+++ b/app/code/Belco/Widget/Helper/Data.php	(revision 6fc332298581c8065c5ce465ea7fb72a95355183)
@@ -8,6 +8,7 @@
 class Data extends \Magento\Framework\App\Helper\AbstractHelper
 {
 
+    public $logger;
     /**
      * @var \Belco\Widget\Model\Api
      */
Index: app/code/Belco/Widget/Model/Api.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/code/Belco/Widget/Model/Api.php b/app/code/Belco/Widget/Model/Api.php
--- a/app/code/Belco/Widget/Model/Api.php	(revision 3c846603dbec5d956d2665105b2d29fb8b5126aa)
+++ b/app/code/Belco/Widget/Model/Api.php	(revision 6fc332298581c8065c5ce465ea7fb72a95355183)
@@ -9,6 +9,7 @@
 class Api
 {
 
+    public $storeManager;
     /**
      * @var \Psr\Log\LoggerInterface
      */
@DjangoZeelig
Copy link

Thank you @pepijnblom,

Question for the Belco Developers:

  • Is this patch considered stable and suitable for production use?
  • Are there any plans to merge this patch into the main codebase?
  • Has this patch been tested for compatibility with the Hyvä theme and Hyvä checkout?

Additionally, the current API implementation is breaking the checkout process, preventing customers from finalizing their payments. I am concerned about the stability of the current implementation and the patch, particularly its impact on critical functionalities like payment processing.

Thank you in advance,

@henkvalk
Copy link
Contributor

@DjangoZeelig You can use falconmedia/magento2-belco-hyva

@henkvalk
Copy link
Contributor

@DjangoZeelig

I added a PR for the Checkout error #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants