Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment text in activity JSON files #129

Closed
certik opened this issue Jul 30, 2020 · 3 comments
Closed

Comment text in activity JSON files #129

certik opened this issue Jul 30, 2020 · 3 comments

Comments

@certik
Copy link
Member

certik commented Jul 30, 2020

Currently we store each comment together with the metadata in the activity JSON files. Do we need to do that? I think the JSON files might become much smaller without the text of the comments. I don't know if we might want to need them in the future, but even if so, I would imagine only to show some statistics (number of words / sentences written?), so it seems to me we can have some separate repository that can store the comments, but the JSON files that we need for this website should only contain things we actually need, which is just the metadata (plus any possible statistics about comments if we want in the future), but not the comments themselves.

@LKedward
Copy link
Member

Yes you are right, we don't need all the data we are currently storing.
My long term plan has been to perform more pre-processing in the python script before dumping to json; every time the contributor data is loaded on a webpage, the json data has to be processed in javascript (this function) to extract a list of contribution dates per user. This is obviously wasteful on the client-side since this processingt can be performed a priori.

@certik
Copy link
Member Author

certik commented Jul 30, 2020

Yes, exactly.

@awvwgk
Copy link
Member

awvwgk commented Aug 6, 2022

For the new webpage at https://github.com/fortran-lang/webpage we found a solution not requiring to store the JSON data as part of the repository, this issue will therefore be resolved once we migrate to the new page (see #415).

@awvwgk awvwgk closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants