You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #100 adds a Javascript library and JSON data files - as discussed in this PR, these are best left out of the main repository. In the case of the JSON files, this is because of their file size.
Two solutions I can think of:
Add a shell script for cloning and updating dependencies from their respective repositories -
script is run in CI and by contributors at checkout;
Use git submodules.
My preference is for submodules:
Submodules are designed specifically for this purpose
I don't like the idea of maintaining a shell script
Checking-out submodules is a simpler workflow than requiring contributors to run a shell script
My impression is that the issues people face with submodules are usually when pushing commits to repositories from submodules - we won't be doing that.
The text was updated successfully, but these errors were encountered:
PR #100 adds a Javascript library and JSON data files - as discussed in this PR, these are best left out of the main repository. In the case of the JSON files, this is because of their file size.
Two solutions I can think of:
Add a shell script for cloning and updating dependencies from their respective repositories -
script is run in CI and by contributors at checkout;
Use git submodules.
My preference is for submodules:
My impression is that the issues people face with submodules are usually when pushing commits to repositories from submodules - we won't be doing that.
The text was updated successfully, but these errors were encountered: