Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External dependencies #102

Closed
LKedward opened this issue Jun 8, 2020 · 1 comment
Closed

External dependencies #102

LKedward opened this issue Jun 8, 2020 · 1 comment

Comments

@LKedward
Copy link
Member

LKedward commented Jun 8, 2020

PR #100 adds a Javascript library and JSON data files - as discussed in this PR, these are best left out of the main repository. In the case of the JSON files, this is because of their file size.

Two solutions I can think of:

  1. Add a shell script for cloning and updating dependencies from their respective repositories -
    script is run in CI and by contributors at checkout;

  2. Use git submodules.

My preference is for submodules:

  • Submodules are designed specifically for this purpose
  • I don't like the idea of maintaining a shell script
  • Checking-out submodules is a simpler workflow than requiring contributors to run a shell script

My impression is that the issues people face with submodules are usually when pushing commits to repositories from submodules - we won't be doing that.

@awvwgk
Copy link
Member

awvwgk commented Aug 19, 2022

Resolved with migration to the new webpage in #415

@awvwgk awvwgk closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants