Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics in locator results #14

Open
fleimgruber opened this issue Dec 14, 2022 · 3 comments
Open

Diacritics in locator results #14

fleimgruber opened this issue Dec 14, 2022 · 3 comments

Comments

@fleimgruber
Copy link

In https://github.com/fneum/core-tso-data/blob/main/outputs/locator-results.csv it seems that the diacritic "ue" was wrongly replaced by "ü", e.g. "Taürn AT" vs. "Tauern AT" and "Neünhagen DE" vs. "Neuenhagen DE". I understand that the automatic matching is fuzzy and all, but maybe this specific diacritics conversion could be fixed? I think this is also the reason why the GIS coordinates are not present for these nodes.

@fneum
Copy link
Owner

fneum commented Dec 16, 2022

Yes, that bothered me as well, but I didn't fix it yet.

@fleimgruber
Copy link
Author

fleimgruber commented Dec 21, 2022

What is the reason for https://github.com/fneum/core-tso-data/blob/main/scripts/process_data.py#L175? Is it because previous transformations resolved diacritics and they are regenerated here? If so then we could easily extend the list of false positives (as you did with "Itzehoe" etc.) and I could contribute that.

@fneum
Copy link
Owner

fneum commented Dec 27, 2022

Yes, that would be a good solution. The original reason for the transformation was that the geolocator had difficulties resolving e.g. Koeln.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants