Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380/mfd): trip fuel calculation & block not editable across flights in fuel & load #9788

Merged

Conversation

BravoMike99
Copy link
Contributor

Fixes #[issue_no]

Summary of Changes

Fixes wrong landing weight value in mfd fuel & load.
Clear taxi fuel once outside of preflight phase rather than setting 0.
Fixes block fuel not being editable across flights.

Screenshots (if necessary)

LW
Taxi

References

Additional context

Discord username (if different from GitHub): bruno_pt99

Testing instructions

  1. Program the FMS with any route of your choice.
  2. Verify that the landing weight value displayed on the fuel & load page goes in line with the predictions.
  3. Verify that you can insert a manual taxi fuel entry and that the font becomes bigger if a manual entry was performed. Once deleted, the font should become smaller and revert to a value of 1.5T.
  4. Change the FMS to takeoff phase by setting toga thrust for example. TO phase can be verified by green "TO" in the MFD performance page. Verify the taxi fuel is dashed in the FUEL & LOAD page and not editable.
  5. Shutdown the engines, verify it is possible to edit the block fuel after the FMS resets ( < 20% N2) in the fuel & load page.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BravoMike99 BravoMike99 changed the title fix(a380/mfd): wrong trip fuel & block fuel not editable across flights in fuel & load fix(a380/mfd): trip fuel calculation & block not editable across flights in fuel & load Jan 19, 2025
Copy link
Contributor

@flogross89 flogross89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BravoMike99 BravoMike99 added QA Tier 1 QA Ready to Test A380X Related to the A380X aircraft labels Jan 20, 2025
@utkrishtm
Copy link

Quality Assurance Trainee Report

Discord Username : utkrishtm
Object of testing : #9788
Aircraft : A380X
Tier of Testing : 1
Date : 22/01/2025

Testing Process:

  • Loaded route into FMS
  • Verify that the landing weight value
    • Small discrepency, nothing major
    • Estimated LW from Simbrief: 362.3 T
    • Estimated displayed on the Fuel & Load Page: 368.5 T
  • Font and logic for manual taxi fuel works

9788_taxiFuel

9788_TaxiFuelNotChanged

9788_TOStage

9788_FMSreset

Testing Results:
Passed

Negatives:

  • As soon as I click on the taxi fuel entry (preflight phase), if the value is not changed, the font still becomes bigger. The font shouldn't change if the value was not changed.

Media:
9788_fuelPage

@BravoMike99
Copy link
Contributor Author

Quality Assurance Trainee Report

Discord Username : utkrishtm Object of testing : #9788 Aircraft : A380X Tier of Testing : 1 Date : 22/01/2025

Testing Process:

  • Loaded route into FMS

  • Verify that the landing weight value

    • Small discrepency, nothing major
    • Estimated LW from Simbrief: 362.3 T
    • Estimated displayed on the Fuel & Load Page: 368.5 T
  • Font and logic for manual taxi fuel works

9788_taxiFuel

9788_TaxiFuelNotChanged

9788_TOStage

9788_FMSreset

Testing Results: Passed

Negatives:

  • As soon as I click on the taxi fuel entry (preflight phase), if the value is not changed, the font still becomes bigger. The font shouldn't change if the value was not changed.

Media: 9788_fuelPage

Thanks for testing 👍 . The font changing size even if the value hasn't changed happens across many MFD fields. Perhaps you could raise an issue about that

@BravoMike99 BravoMike99 enabled auto-merge (squash) January 23, 2025 20:54
@BravoMike99 BravoMike99 merged commit 4b4b498 into flybywiresim:master Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

3 participants