New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes on metrics #212

Open

vsoch opened this issue Jan 6, 2024 · 0 comments

Member

vsoch commented Jan 6, 2024 •

edited

Loading

Note that if we ever need the flux operator to export metrics, kubebuilder has a default setup: https://book.kubebuilder.io/reference/metrics

However there are ways to do this on our own (my preference, but would need to understand integration with the above). Here is from kueue.

https://github.com/kubernetes-sigs/kueue/blob/main/pkg/metrics/metrics.go

Another interesting thing I'm noticing is that kueue (as an operator) does seem to hold some basic state (e.g., here the maps) https://github.com/kubernetes-sigs/kueue/blob/ed81667f0554345cfc5c956a28b8ad62564bcc81/pkg/queue/manager.go#L49-L50 and I'm questioning my assumption that this is bad practice. There are cases when I've wanted something like this for an idea but dismissed it because of that! It seems to use a "dumper" that does exactly that 💩 on a signal to stop. https://github.com/kubernetes-sigs/kueue/blob/main/pkg/debugger/debugger.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment