Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Reply UI bugs #567

Open
8 tasks
guidezpl opened this issue Dec 9, 2021 · 0 comments
Open
8 tasks

Reply UI bugs #567

guidezpl opened this issue Dec 9, 2021 · 0 comments
Labels
a11y Related to accessibility bug Something isn't working demo Building/fixing/updating a demo P2 Priority 2 - Should have

Comments

@guidezpl
Copy link
Member

guidezpl commented Dec 9, 2021

  • janky transition
    Kapture 2023-02-10 at 12 59 34
  • Removing an email from inbox through the action item, does not animate: When an email is deleted through the action bar located in the MailPreviewCard on larger screens, and the BottomAppBarActionItems on smaller screens, there is no animation to show the email being dismissed from the inbox. The email instantly dissapears. The email should show a dismissing animation, similar to when an email is dismissed by swiping from start to end, and the email should animate as it exits the inbox.
  • Bottom drawer destinations not visible on devices with small screens: The bottom drawer on the reply material study is not a scrollable widget. So, if a device's screen is too small to fit the content of the bottom drawers destinations, then that device won't be able to navigate to said destinations.
  • Contextual bottom app bar icons don't fade in from the center: The icons in the contextual bottom app bar look like they fade in from the right of the screen, rather than coming in from the center.
  • Bottom drawer animations are not consistent: The bottom drawer closes too fast, it is currently set at a duration of 300ms, but it closes way faster. The Floating action button should also enter/exit smoothly with the bottom drawer. Floating action button animation should use standardEasing. The bottom drawer should animation open/close at a duration of 250ms with standardEasing. The fab should enter/exit smoothly with the bottom drawer.
  • Mobile FAB uses SizedBox instead of FAB: Because of an a11y issue with the animations package, we use a SizedBox instead of a fab. A SizedBox does not retain the visual states of a FAB so this is a workaround until this issue is fixed in the animations package. Should ensure a floating action button works as the returned widget in OpenContainer closedBuilder property.
  • Use onGenerateRoute for navigating to SearchPage: In order to navigate to the SearchPage we use a PageTransitionSwitcher and the onSearchPage property in our EmailStore, to switch between the SearchPage and the HomePage. Originally this was implemented through onGenerateRoute, but because of a bug a workaround was put in place. PR. Should use onGenerateRoute and namedRoutes to navigate to SearchPage. Something like Navigator.of(context).pushNamed('/reply/search/');
  • Fade through transition between navigation rail destinations broken: The fade through transition that occurs when tapping on different navigation rail destinations is not working. Tapping different destinations does not yield a transition. Looks like this was introduced in [State Restoration] [Reply] Partially State Restorable Pages #368.
@guidezpl guidezpl added bug Something isn't working P3 Priority 3 - Could have a11y Related to accessibility demo Building/fixing/updating a demo labels Dec 9, 2021
@guidezpl guidezpl added P2 Priority 2 - Should have and removed P3 Priority 3 - Could have labels Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y Related to accessibility bug Something isn't working demo Building/fixing/updating a demo P2 Priority 2 - Should have
Projects
None yet
Development

No branches or pull requests

1 participant