Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluid-publish should revert package-lock.json on conclusion #22

Open
jobara opened this issue Jul 25, 2024 · 6 comments
Open

fluid-publish should revert package-lock.json on conclusion #22

jobara opened this issue Jul 25, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@jobara
Copy link
Member

jobara commented Jul 25, 2024

Describe the bug

npm version 5, the current LTS version, maintains a package-lock.json file in addition to package.json . The last step of the fluid-publish dev workflow should revert this file to its content from git in addition to the package.json file

Additional context or notes

Migrated from FLUID-6250. Originally filed by @amb26 on February 22, 2018

@jobara jobara added the bug Something isn't working label Jul 25, 2024
@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @atisayajain on March 12, 2018

Is this issue still open? I would like to work on this.

@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @jobara on March 12, 2018

@atisayajain I believe this is still open. Please feel free to submit a PR to address it.

@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @atisayajain on March 12, 2018

This might be silly, but I think I am a bit lost here. What does it mean to revert back to content from git? Does it mean that after publishing, fluid-publish should be removed from the package-lock.json and package.json files of the module it has been used to publish? Or does it mean something else?
I would be grateful if you could help me how to approach this issue.

@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @the-t-in-rtf on March 13, 2018

Hi, @atisayajain. For "dev" releases, this package generates a version number (based in part on the date) that is saved to the package.json file. The updated package.json file is committed as part of a new tag. Once this is done, the goal is to leave the current working branch in the same state it was in before the release. We accomplish this by checking out the previous package.json from whatever branch we are working in.
This ticket covers also reverting the package-lock.json file, as though we had issued the command git checkout package-lock.json.

@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @atisayajain on March 13, 2018

Thank you so much for you help, Tony. It cleared a lot of doubts, really.
I have opened a PR #9 on Github, please review it. And please let me know if any other changes need to be made.

@jobara
Copy link
Member Author

jobara commented Jul 25, 2024

Comment Migrated from FLUID-6250 originally posted by @atisayajain on March 16, 2018

@jobara @the-t-in-rtf I closed the previous PR while trying to rename commits. I am really sorry for this.
Please review PR #10 Github and let me know if any changes need to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant