Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player config UI rethink #95

Open
fluffy-critter opened this issue Oct 30, 2023 · 1 comment
Open

Player config UI rethink #95

fluffy-critter opened this issue Oct 30, 2023 · 1 comment
Labels
code quality paying down technical debt gui Stuff pertaining to the GUI

Comments

@fluffy-critter
Copy link
Owner

fluffy-critter commented Oct 30, 2023

It’s getting overly complicated to try to support different player options from a modular interface and theme options will be pretty universal across players, probably.

so let’s have a row of theme colors (and a player selector if that ever happens), and a “custom css” file selector field, which should cover all the bases. Don’t overcomplicate without a specific use case.

it’s still good to namespace player theme stuff but plop that into a generic “player” section rather than making it per-player.

@fluffy-critter fluffy-critter added gui Stuff pertaining to the GUI code quality paying down technical debt labels Oct 30, 2023
@fluffy-critter
Copy link
Owner Author

Feedback from a user indicates that it isn't super obvious that the per-track metadata just overrides album metadata and doesn't need to be set on an individual basis except for exceptions. Maybe say "track genre" "track composer" etc. (like how "track artist" is already)

The whole top "album metadata" section is a mess right now and could probably be put into the track selector similarly to how Bandcamp does it.

"Build options" could probably be laid out better as well, as it isn't super clear what each of the options actually does or how they interact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality paying down technical debt gui Stuff pertaining to the GUI
Projects
None yet
Development

No branches or pull requests

1 participant