Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors not displaying when encode fails #86

Open
fluffy-critter opened this issue Oct 27, 2023 · 0 comments
Open

Errors not displaying when encode fails #86

fluffy-critter opened this issue Oct 27, 2023 · 0 comments
Labels
bug Something isn't working gui Stuff pertaining to the GUI

Comments

@fluffy-critter
Copy link
Owner

fluffy-critter commented Oct 27, 2023

Got the following exception from some incorrect app settings:

Traceback (most recent call last):
  File "/Users/fluffy/projects/bandcrash/bandcrash/__init__.py", line 71, in run_encoder
    subprocess.run([util.ffmpeg_path(),
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/Users/fluffy/.pyffmpeg/bin/ffmpeg', '-hide_banner', '-loglevel', 'error', '-i', '/Volumes/home/Music/albums/radio ready/wav/Better Than Before.wav', '-b', '32', '-V', '5', '-q', '5', '-m', 'j', '-y', '/Users/fluffy/Music/asdf/Sockpuppet - Radio Ready/preview/03 Better Than Before.mp3']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/fluffy/projects/bandcrash/bandcrash/gui/__init__.py", line 572, in encode_album
    task.result()
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/fluffy/projects/bandcrash/bandcrash/__init__.py", line 103, in encode_mp3
    run_encoder(in_path, out_path, encode_args)
  File "/Users/fluffy/projects/bandcrash/bandcrash/__init__.py", line 81, in run_encoder
    os.remove(outfile)

For some reason this led to the encode just silently failing with no message dialog appearing.

This happened on v0.5.1-9f31dfe

@fluffy-critter fluffy-critter added bug Something isn't working gui Stuff pertaining to the GUI labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui Stuff pertaining to the GUI
Projects
None yet
Development

No branches or pull requests

1 participant