Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Annotation support to fluent-operator Deployment #456

Closed
momoXD007 opened this issue Nov 22, 2022 · 2 comments
Closed

add Annotation support to fluent-operator Deployment #456

momoXD007 opened this issue Nov 22, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@momoXD007
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am frustrated because I can not add an annotation to fluent-operator Deployment or Pods. There is no way in the templates provided to add annotations.

Describe the solution you'd like

Basically I just want annotations to be considered in fluent-operator-deployment.yaml and an option to overwrite annotations via values.yaml
A similar think is already implemented for fluent-bit.

Additional context

Many people rely on annotations in kubernetes to supply context. Annotations are used to control prometheus behaviour towards this pod or might be used to tell a security-provider in a cluster that a certain pod can or can not do certain things.

In short supporting annotations is a good practice and large scale production environments will need them.

@wenchajun wenchajun added the good first issue Good for newcomers label Nov 23, 2022
@momoXD007
Copy link
Contributor Author

Looking at the source-code and templates again: I think it should be seriously considered to support arbitrary labels for fluent-bits fluentds and fluent-operator as well.
I believe for fluent-operator this is can possibly be solved purely in the templates. For fluent-bit I guess template and fluentbit-types.yaml need enhancement

For fluentd I did not check but probably same approach as fluent-bit should work.

@squaricdot
Copy link

this can be closed right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants