Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing failed with Cannot read properties of undefined (reading 'filter') #1814

Open
1 task done
alfredonodo opened this issue Jan 5, 2025 · 13 comments
Open
1 task done

Comments

@alfredonodo
Copy link

Which version of floccus are you using?

5.4.0

How many bookmarks do you have, roughly?

1000

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

LibreWolf 133.0.3-1, Brave nightly 1.75.142

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

wölkli nextcloud free

Describe the Bug

LibreWolf is able to synchronise to the cloud while Brave as of today no longer synchronises and I get.

2025-01-05T10:13:45.270Z Starting sync process for account 
2025-01-05T10:13:45.275Z onSyncStart: begin
2025-01-05T10:13:46.916Z onSyncStart: completed
2025-01-05T10:13:46.997Z Failed to load pending continuation. Continuing with normal sync
2025-01-05T10:13:46.997Z Using "merge slave" strategy (no cache available)
2025-01-05T10:13:46.997Z Retrieving local tree
2025-01-05T10:13:47.000Z Filtering out unaccepted local bookmarks
2025-01-05T10:13:47.000Z Syncing failed with Cannot read properties of undefined (reading 'filter')
2025-01-05T10:13:47.002Z onSyncFail

Expected Behavior

A correct synchronisation that worked well until 1 month ago.

To Reproduce

  1. Install LibreWolf, Brave and Floccus
  2. Synchronise LibreWolf to the cloud
  3. Synchronise the cloud to Brave

Debug log provided

  • I have provided a debug log file
@alfredonodo alfredonodo added the bug label Jan 5, 2025
Copy link

github-actions bot commented Jan 5, 2025

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

mmmh, I cannot reproduce this with Brave 1.73.104 (Chromium: 131.0.6778.204 (Official Build)), can you try with Brave non-nightly?

@github-project-automation github-project-automation bot moved this to Backlog in Floccus Jan 6, 2025
@marcelklehr marcelklehr moved this from Backlog to Triaging in Floccus Jan 6, 2025
@marcelklehr marcelklehr changed the title Syncing failed with Cannot read properties of undefined (reading 'filter') Brave: Syncing failed with Cannot read properties of undefined (reading 'filter') Jan 6, 2025
@ThubLives
Copy link

My debug log looks pretty much identical, though I'm using Chrome. Apparently it's been failing for 5 months now.

Floccus 5.4.0
Chrome 131.0.6778.206 (Official Build) (64-bit)

@marcelklehr marcelklehr changed the title Brave: Syncing failed with Cannot read properties of undefined (reading 'filter') Syncing failed with Cannot read properties of undefined (reading 'filter') Jan 12, 2025
@marcelklehr
Copy link
Member

Ok, so it's not a Brave issue, then.

@marcelklehr
Copy link
Member

@GrantRobertson has the same on Chrome #1823

@marcelklehr
Copy link
Member

marcelklehr commented Jan 12, 2025

Do you all happen to have multiple possibly nested profiles in floccus? Possibly with nested sync disabled in some of them?

@GrantRobertson
Copy link

Do you all happen to have multiple possibly nested profiles in floccus? Possibly with nested sync disabled in some of them?

I just had the most basic of installs. No special anything. I literally just installed the extension, kept the defaults, and tried to sync all of my bookmarks up to your service.

@marcelklehr
Copy link
Member

@GrantRobertson did you export the profile from a different browser and import it to another one where it then didn't work? Which Bookmarks folder did you select to be synced?

@GrantRobertson
Copy link

@GrantRobertson did you export the profile from a different browser and import it to another one where it then didn't work? Which Bookmarks folder did you select to be synced?

@marcelklehr Nope. This was literally my first try at using the software. I just selected the root folder of my bookmarks, as suggested in the documentation.

@marcelklehr
Copy link
Member

marcelklehr commented Jan 12, 2025

Huh. I'm stumped. I cannot reproduce this. headscratch

There seems to be some inconsistency in your bookmarks somehow.

@marcelklehr marcelklehr pinned this issue Jan 12, 2025
@GrantRobertson
Copy link

Huh. I'm stumped.

@marcelklehr When I chose the root directory, your dialog box showed the name of that folder as "Undefined" or something like that. I am pretty sure that I also tried simply synchronizing the "Bookmarks Bar" folder, but I got the same error, so I switched back to having selected the root.

I do have a gigantic buttload of old bookmarks, going all the way back to when I was using Netscape Navigator, back it the olden times. I just keep importing old bookmarks when I switch to a new browser. However, I have been using Chrome exclusively for over a decade, IIRC. And, one would expect that the import process would have cleaned up any funky bookmark entries from previous browsers.

@marcelklehr
Copy link
Member

@GrantRobertson Can you perhaps try creating a new profile and see if it works there? (Not sure how/if that works on chrome)

@GrantRobertson
Copy link

@GrantRobertson Can you perhaps try creating a new profile and see if it works there? (Not sure how/if that works on chrome)

I've got other Chrome profiles that I could try it on. But I'm not super inclined, at this point. I need to get breakfast. I may try it later.

If it did work on some other profile, Floccus would still be of little benefit to me, because that would still mean that I would have to clean up and purge my main bookmarks collection before I could synchronize it to my other Chrome profiles. And I am totally not up for that chore today. I have kind of just accepted that I will have to just keep the bookmarks separate for each profile. I created my other Chrome profiles, mostly, just to be able to easily log into a small set of different websites where I have multiple accounts (like Reddit), without needing to constantly log out then back in under different accounts. So, I really only need to have just a few bookmarks for those other Chrome profiles.

Trying Floccus was mostly just the result of me diving a bit too deep down a rabbit hole that I kinda didn't need to go down anyway. You know how that goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triaging
Development

No branches or pull requests

4 participants