Tab Sync fails if pipe character "|" exists in page title

[shirocko]

Which version of floccus are you using?

5.4.0

How many bookmarks do you have, roughly?

1500

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Chrome 131.0.6778.205

Which version of Nextcloud Bookmarks are you using? (if relevant)

15.0.4

Which version of Nextcloud? (if relevant)

30.0.4

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

If I try so sync my open tabs with Nextcloud via floccus and one tab is the startpage of t-online.de, then one of the following errors occur.
When I navigate to a subpage of t-online.de then the sync is working.
It seems that maybe the "|" in the page title of the startpage is causing that problem.

It seems that the first message E035 is displayed because the sync doesn't work for a long time.
The seccond error E019 occurs directly after I had once a working sync and then navigate back to the startpage and the sync fails again.

The only error I see in the Nextcloud Docker Log Output is:

bookmarksync [04/Jan/2025:21:01:25 +0000] "PUT /index.php/apps/bookmarks/public/rest/v2/bookmark/3785 HTTP/1.1" 500 1934

Expected Behavior

The tabs should synchronize independent of characters in the page title.

To Reproduce

Open one or more browser tabs and one is the startpage of t-online.de, then the errors will occur.

Debug log provided

• I have provided a debug log file

Similar error: #1800

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

Hello @shirocko

The only error I see in the Nextcloud Docker Log Output is:
bookmarksync [04/Jan/2025:21:01:25 +0000] "PUT /index.php/apps/bookmarks/public/rest/v2/bookmark/3785 HTTP/1.1" 500 1934

This seems to be from the Apache log; nextcloud has a separate log file, though, which logs the full error message that caused the 500 response. This would be vital to obtain.

[shirocko]

Sadly there is no entry written in the nextcloud.log when the error occurs.
As I said I am using Nextcloud as a docker container and there the nextcloud log is written to /var/www/html/data/nextcloud.log
There are some errors inside regarding REDIS, but not regarding the Error 500.
I tried it several times and the log does not write any new entries.

[marcelklehr]

Ah, then I think I know what the problem is.

[marcelklehr]

Should be fixed with the upcoming release

[marcelklehr]

New release is out now, please report back here, if this issue is not fixed with the new release.

[shirocko]

Thanks for the quick reply and new release.
I just installed it in chrome, but the error itself still exists. Only the error message in floccus is a bit different:

E035: Failed to create the following bookmark on the server: - #3802;938News & E-Mail bei t-online | Politik, Sport, Unterhaltung & Ratgeber parentId: 938 | Zuletzt synchronisiert: vor 4 Minuten

As before the nextcloud.log does not show any error for that time.

[marcelklehr]

Mmh, in that case the other explanation for this error is that you have multiple bookmarks for the same URL in the database. Are you comfortable with diving into the SQL console of your Nextcloud database? Then you could check the oc_bookmarks table for duplicate entries with the same url with the following query:

SELECT url, COUNT(*) AS duplicate_count FROM oc_bookmarks GROUP BY url HAVING COUNT(*) > 1;

[shirocko]

Well...:D
Summarized the output is the following:

26 urls that exist 2 times
5 urls that exist 3 times
AND
one url, t-online.de, that exist 23 times

What is curious is that if I search the url within the browser or within Nextcloud Bookmarks plugin I don't find it a single time only as the start page without sub urls.

Edit:
I tried to delete the tab synchronisation in floccus and also the corresponding folder in Nextcloud Booksmarks.
After that I configured a new tab synchronisation with a different profile/folder name for Nextcloud, but the same error still exist. And also the count of 23 entries in the db ist still the same.

Can I somehow check if the duplicated entries for that one domain are still a valid entry or if that are zombie entries in the db?

[marcelklehr]

one url, t-online.de, that exist 23 times

That's curious.

Can you try the following query, which will count the number of duplicates per user?

SELECT url, COUNT(*) AS duplicate_count, user_id FROM oc_bookmarks GROUP BY url, user_id HAVING COUNT(*) > 1;

[marcelklehr]

What is curious is that if I search the url within the browser or within Nextcloud Bookmarks plugin I don't find it a single time only as the start page without sub urls.

Yeah, that makes sense, because the bookmarks app cannot handle duplicate URLs in any way, so I guess they will just disappear.

[shirocko]

Okay I chose the radical path.
I delete all floccus configs, delete all bookmarks entries in Nextcloud and also reinstalled the bookmarks plugin in Nextcloud and also floccus in the browser.
There 23 entries were 10 old entries in the recycle bin, 10 somewhere hidden in the bookmark sync user profile and 3 in the admin server profile of nextcloud.
After i delete everything and configured freshly the sync is working again, also for the tabs and the domain t-online.de

So I guess the duplicated entry maybe have been created during several sync conflict in the past and instead of deleting the old entries, the system added the same bookmarks again und let them be as zombies in the database.

For now the error is fixed for me, but I will see how stable the tab sync is in the future with 2 laptops using the nextcloud instance to exchange there open tabs.

Thank you for your quick response and help.

[marcelklehr]

Yep, removal from the database would have been my next suggestion as well. If you hit new problems don't hesitate to open an issue here :)