Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apriori algorithm also for better comparison #88

Open
minakshikaushik opened this issue Mar 16, 2023 · 6 comments
Open

Add Apriori algorithm also for better comparison #88

minakshikaushik opened this issue Mar 16, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minakshikaushik
Copy link

No description provided.

@minakshikaushik minakshikaushik changed the title Add Apriori algorithm Add Apriori algorithm also for better comparison Mar 16, 2023
@firefly-cpp
Copy link
Owner

Thanks, @minakshikaushik.

This is a good point. Although NiaARM is more or less oriented for numerical association rule mining, having a referential Apriori implementation in this repository would be beneficial for comparison, as you mentioned.

@zStupan, what do you think? Are you interested in adding basic Apriori implementation? Employing some classes from NiaARM may help speed up the performance. The discretization step exists in the tinynarm library.

By the way, there is a lack of pure Python Apriori implementations equipped with good documentation and still under active maintenance.

@firefly-cpp firefly-cpp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 16, 2023
@firefly-cpp
Copy link
Owner

@zStupan, what do you think?

@zStupan
Copy link
Collaborator

zStupan commented Mar 21, 2023

Hello,

sorry for the late response, I don't really have a lot of free time right now... We could add an implementation of Apriori, although there are already some popular implementations out there (efficient-apriori).

So if I understand correctly, the comparison would be our method vs discretization and then running apriori?

@firefly-cpp
Copy link
Owner

@minakshikaushik, what do you think/need?

A comparison that may be suitable is our method using discrete dataset vs. apriori in terms of the number of rules generated, supports, confidences and time (very important), etc.

@zStupan, do you think including any existing implementations may be more convenient?

@minakshikaushik
Copy link
Author

@firefly-cpp
Your idea "our method using discrete dataset vs. apriori in terms of the number of rules generated, supports, confidences and time (very important), etc." is good.

@firefly-cpp
Copy link
Owner

@zStupan, any progress, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants