Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security reports with path-to-regexp version #478

Closed
javierjulio opened this issue Sep 20, 2024 · 10 comments
Closed

Security reports with path-to-regexp version #478

javierjulio opened this issue Sep 20, 2024 · 10 comments

Comments

@javierjulio
Copy link

We have two Dependabot security reports regarding the path-to-regexp version and since we use firebase-tools, I believe it's coming from this package. This Dependabot PR #476 here would resolve it since the router package also depends on a vulnerable path-to-regexp version so both need to be updated. Worth noting that the router package is a major version update.

@baraknaveh
Copy link

Same here, would be great if the team can give #476 a little love...

@cam-at-tactiq
Copy link

This is affecting us too.

@mgm793
Copy link

mgm793 commented Oct 21, 2024

Any update here?

@mgm793
Copy link

mgm793 commented Oct 21, 2024

I created a PR to fix it: #482

@IchordeDionysos
Copy link

This is now fixed

@moekify
Copy link

moekify commented Dec 6, 2024

@IchordeDionysos This is not fixed yet, CVE-2024-45296 is still open GHSA-9wv6-86v2-598j in this repository given that path-to-regexp is still on v1.8.0

@IchordeDionysos
Copy link

True, the issue here is fixed though downstream consumers are not locked into a vulnerable version as the lockfile of superstatic shouldn't be used.

Unless you use superstatic directly (which is likely the minority of the cases) you are not blocked.

@moekify
Copy link

moekify commented Jan 9, 2025

@IchordeDionysos Yes, but it means we need to monkeypatch and override a version. It would be preferable to deal with security vulnerabilities at the source. Most people probably come here via firebase-tools

@joehan
Copy link
Contributor

joehan commented Jan 22, 2025

This is fixed after the recent package-lock.json regen, but #488 will update package.json to match.

@joehan joehan closed this as completed Jan 22, 2025
@moekify
Copy link

moekify commented Jan 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants