Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap doesn't account for panning #96

Open
fire-eggs opened this issue Oct 4, 2021 · 5 comments
Open

Minimap doesn't account for panning #96

fire-eggs opened this issue Oct 4, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@fire-eggs
Copy link
Owner

If the current image size is smaller than the window, the minimap is not drawn.

However, the image could be panned such that it extends outside the window. Ideally the minimap should be drawn in that situation.

@fire-eggs fire-eggs added the enhancement New feature or request label Oct 4, 2021
@fire-eggs fire-eggs changed the title Minimap doesn't account for scrolling Minimap doesn't account for panning Oct 4, 2021
@rageworx
Copy link
Collaborator

Dear @fire-eggs ,
It is not actually expected issue, because minimap was made for displaying anytime even image size is smaller than render widget space.
Is it looks minimap bug ? Or something difference between of sequence to draw minimap when displaying image is smaller than display widget space ?
Let me know, Regards, Raph.

@fire-eggs
Copy link
Owner Author

Hi, Raph, thank you for the follow-up. If there is a problem I'm sure it's in my code. Need to review these issues and see which are relevant any more...

@rageworx
Copy link
Collaborator

Ok, I will help you solve this issue !

@fire-eggs
Copy link
Owner Author

Somewhere there is code that disables the minimap when the current image size is smaller than the view.

Either:

  • the minimap should be on at all times [if enabled]
  • the minimap should re-show if the image is panned outside the view

I think I'm inclined to the first choice.

@fire-eggs
Copy link
Owner Author

Doing something wrong when the image is smaller than the window:

image

Note how the blue rectangle [the window-rect] is cut off at top and right.

I think I've used the image rect as the "master" and drawing the window-rect proportionally. Possibly need to have a fixed-size window-rect and draw the
image-rect proportionally, when the image is smaller than the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants