re-running build

[jty]

Hi, thanks for the great toolchain.

I noticed that when I re-run mussel, the mpackage() detects that package is already there and says it is skipping, but still it goes ahead.
Is there a return missing after line 644?

[firasuke]

Hi, thanks for the great toolchain.

Glad you liked it!

... but still it goes ahead.

It goes ahead as in, it tries to download the package again? or it attempts to rebuild the package even if it has already been built?

[jty]

It downloads and builds again. Just looking into the mpackage function I assumed the function should return when detecting source is there

[firasuke]

It downloads and builds again. Just looking into the mpackage function I assumed the function should return when detecting source is there

@takusuman summoning you, perhaps we should have some sort of a simple caching mechanism to prevent downloading and building again?

[takusuman]

G'day, Firas. Pardon for the delay, I've been working in the last days.
Well, we already cache downloads; making it cache a build would be another thing to implement. Maybe just keep the build directory intact until it successfully finishes or the user decides to delete it?

[takusuman]

Well, could you run it again, this time debugging it with the -x option?
Like that: dash -x ./mussel <insert your options here>
I'm currently really busy, so I can't do it for you now.

PS: You should file a ticket for it as an issue, since it is possibly a bug at the nettransfer() function.

[jty]

I looked into the script more closely and realised I had misunderstood the functionality. I assumed that if the directory is already there, the script will skip downloading and assume the right source is available. However if the directory is there, it only skips the creation of the directory and tells the user it is skipping... which I confused to skipping the downloading and building.
Thus the only fix I would propose is to clarify the message in line 644:
printf "${YELLOWC}!.${NORMALC} $1 source directory already exists, skipping...\n"
to
printf "${YELLOWC}!.${NORMALC} $1 source directory already exists, skipping creation...\n"
or just removing lines 643 and 644
Anyways, this script saves a lot of work, so thank you again

[takusuman]

printf "${YELLOWC}!.${NORMALC} $1 source directory already exists, skipping...\n"
to
printf "${YELLOWC}!.${NORMALC} $1 source directory already exists, skipping creation...\n"
or just removing lines 643 and 644

Right, we can do it. Much obliged for the suggestion, and also for appreciating this project.

Anyways, this script saves a lot of work, so thank you again

You're welcome.

I forgotten to say: @firasuke, could we have this as a "to-do"? I'm a little busy lately.

[firasuke]

I forgotten to say: @firasuke, could we have this as a "to-do"? I'm a little busy lately.

Sure.