Modify level construction to allow querying #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/finch/levels.py
Outdated
| if data is None: | ||
| return jl.Element(fill_value) | ||
|
|
||
| return jl.Element(fill_value, data) |
There was a problem hiding this comment.
eventually let's pass in types here too, like jl.Element[fill_value, dtype](data)
|
Hi @willow-ahrens, I think you can invite Hameer to |
|
Done! |
hameerabbasi
force-pushed
the
construct
branch
3 times, most recently
from
cb9a5ca to
97e7f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13