Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for handling unlabeled points #96

Open
accoumar12 opened this issue Nov 26, 2024 · 5 comments
Open

Guidelines for handling unlabeled points #96

accoumar12 opened this issue Nov 26, 2024 · 5 comments

Comments

@accoumar12
Copy link

Hi,
I first want to thank you for your amazing model, which we already successfully applied in CAD piece segmentation to retrieve the recto, verso and deburring of sheets metal. Here is some result of the segmentation of a single file.
image
Now we want to extend to other morphologies, such as detecting the holes in the pieces. However, we do not know how to handle gracefully the unlabeled data points for such point clouds.
We first added a class called unlabeled, but the results are not satisfying... Do you recommend anything ? Be aware that most of our points are actually unlabeled so discarding them from the training would be really interesting.

Thanks for any help !

@filaPro
Copy link
Owner

filaPro commented Nov 26, 2024

are you solving instance or semantic segmentation? for semantic segmentation you simply should not calculate loss for unlabeled points. for instance segmentation unlabeled points are also not a problem, as for example on scannet we consider walls and floors unlabeled for instance segmentation

@accoumar12
Copy link
Author

I am solving instance segmentation.
How to translate the fact that a point is unlabeled ? Giving it an arbitrary label Index ?

@filaPro
Copy link
Owner

filaPro commented Dec 2, 2024

Yes I think if your valid classes are 0, ... n_classes - 1, than given a n_classes label for a superpoint will result in ignoring it in instance segmentation.

@accoumar12
Copy link
Author

I am following the s3dis template configuration, and i get errors when using a smaller num_instance_classes than the num_semantic_classes.

@accoumar12
Copy link
Author

For anyone interested, I found a solution to my problem. When using the S3Dis configuration, the PointInstClassMapping_ only takes as argument the num_instance_classes. So also -1 values are assigned to the max label, which makes torch one_hot function not working as expected !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants