Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Godot 4.x #65

Open
IvailoBurov opened this issue Jul 19, 2023 · 5 comments
Open

Update for Godot 4.x #65

IvailoBurov opened this issue Jul 19, 2023 · 5 comments

Comments

@IvailoBurov
Copy link

Hello,
Do you have any plans to update this wonderful plugin for the new version of Godot?
Yesterday I tried to adapt it for Godot 4.1, but I couldn't get a working version.

@fian46
Copy link
Owner

fian46 commented Jul 19, 2023

Hi i haven't trying this plugins for godot 4.1.x since my game is still in the porting process from 3.x to 4.x. yes there is problem with gdscript 1.x to 2.x conversion that requires tons of refactor and internal api changes in godot editor that requires huge refactor in code base. the plugins will stuck with godot 3.x only until either i refactor the plugins or rewrite it completely since godot editor plugins is quite tricky at 4.1.x

@IvailoBurov
Copy link
Author

Thanks for the quick response.
I hope for success. If needed I can comment some parts of the code that are problematic in version 4.1.
At this point I no longer have any errors in the code with the new version of the script, but I still haven't achieved a working solution

@fian46
Copy link
Owner

fian46 commented Jul 20, 2023

yeah i have been trying to port it for 4.1.x but there is too many API changes inside the editor it self probably it will take weeks to re-implement current feature. sadly it is probably will stay on 3.x.x only. the changes in internal API for window is way too many. pull request are welcome for this.

@IvailoBurov
Copy link
Author

Indeed, it takes even more than a week to process. I just finished my translation experiment to Godot 4.2.1 and everything seems to work, including the runtime debugger. Since WebSocketServer does not exist in Godot 4.x, I used a plugin from the asset library. If anyone is interested, I can upload the working translated version here for testing, I just need to clean up some unnecessary comments and print lines I wrote during the translation.

@fian46
Copy link
Owner

fian46 commented Dec 16, 2023

Great you can do pull request for it. Or create new branch 4.1 so old version is still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants