Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real implementation #1

Open
Pzixel opened this issue Jul 10, 2018 · 0 comments
Open

Add real implementation #1

Pzixel opened this issue Jul 10, 2018 · 0 comments

Comments

@Pzixel
Copy link

Pzixel commented Jul 10, 2018

Current implementation uses doubles to calculate PI:

https://github.com/Fewlaps/superpi/blob/37f0f138147a386c2cd21451f96463e5c618ec5f/src/main/java/com/fewlaps/superpi/PiCalculator.java#L11-L14

however, as you probably know double has precision of 15-17 decimal numbers (see wiki). So your code actually is not able to calculate more digits, and therefore it doesn't actually implement superpi algorithm.

I propose to implement it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant