Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fields missing #53

Open
antagomir opened this issue Jun 28, 2023 · 4 comments
Open

Some fields missing #53

antagomir opened this issue Jun 28, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@antagomir
Copy link

The Rahti site http://fennica-fennica.rahtiapp.fi/ seems to be missing some fields that we have previously harmonized, notably e.g. page count and physical dimension info, perhaps also other. Compare:
https://github.com/comhis/fennica/blob/master/inst/examples/overview.md

Todo:

  1. List what fields are missing compared to the earlier version

  2. Decide which to bring in and which to discard

  3. Bring in the omitted ones.

@antagomir antagomir added the enhancement New feature or request label Jun 28, 2023
@antagomir
Copy link
Author

Ok the missing ones seem to be listed here https://github.com/fennicahub/fennica/blob/master/inst/examples/main_in_transfer.R

@JuliaMatveeva217
Copy link
Collaborator

Yes, they are missing.

Has somebody worked on them? Do we need to create polish_functions for these fields from scratch?

@antagomir
Copy link
Author

No. The earlier polish functions are available. They just need to be separated from that script, to have them done per field.

@JuliaMatveeva217
Copy link
Collaborator

Ok, I am working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants