Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bubbling of click events #72

Open
Wartybliggens opened this issue Jun 28, 2018 · 0 comments
Open

Prevent bubbling of click events #72

Wartybliggens opened this issue Jun 28, 2018 · 0 comments

Comments

@Wartybliggens
Copy link

Wartybliggens commented Jun 28, 2018

A big problem I have run into with react-kronos is that click events escape, since kronos does not use event.preventDefault() for clicks on the date chooser dropdown.

Imagine this scenario:

  • A modal overlay with a form in it, including react-kronos.
  • The modal is set up so that clicks outside the modal auto-close it.
  • When the user clicks on the react-kronos dropdown (since it's an absolutely-positioned div, not a child of the modal), it counts as an outside click, so the modal closes. Sorry!

I imagine it would be a pretty simple changeset to address this. At some point I may try and do a pull request if you don't get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant