Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect push method behavior in to TabBarCoordinator #30

Open
AlexeyOkhin opened this issue Jul 25, 2024 · 2 comments
Open

Incorrect push method behavior in to TabBarCoordinator #30

AlexeyOkhin opened this issue Jul 25, 2024 · 2 comments

Comments

@AlexeyOkhin
Copy link

Description

The push method does not work correctly. If you are inside the TabbarCoordinator (tabs are at the bottom) and, for example, HomeCoordinator is launched from the first tab, then if you want to navigate further to SecondCoordinator using navigate(to: SecondCoordinator(), presentationStyle: .push), the next coordinator opens as a sheet on top of the tabbar. Maybe I am using it incorrectly? Please help solve this problem, as it is necessary to open the new coordinator using push, not route.navigate(to: .route).

@felilo
Copy link
Owner

felilo commented Jul 29, 2024

Hi @AlexeyOkhin, thanks for reporting the issue. It is not possible to perform this kind of transition between coordinators at the moment. However, I have been working on it. When this feature is ready, I will let you know.

@AlexeyOkhin
Copy link
Author

Hi @felilo, thanks for answering.
I solved this by signing two different coordinators for the same RouteType and when I need to move from push, I do route.navigate(to: SecondCoordinator().router.MainView)
But I would like to have a separate RouteType for each coordinator.
It's good that you don't abandon the project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants