Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a generic type paramater #9

Open
cmyr opened this issue Jul 5, 2017 · 4 comments
Open

Use a generic type paramater #9

cmyr opened this issue Jul 5, 2017 · 4 comments

Comments

@cmyr
Copy link

cmyr commented Jul 5, 2017

This would be a very small non-breaking ergonomic improvement: it would be nice if the input types were AsRef<str>, which would let the function transparently accept both String and &str.

If this is interesting to you I'd be happy to PR.
@febeling
Copy link
Owner

febeling commented Jan 2, 2018

That sounds nice. PR would be most welcome.

@febeling
Copy link
Owner

febeling commented Sep 2, 2018

Close due to inactivity. Please reopen if required.

@febeling febeling closed this as completed Sep 2, 2018
@Zanderwohl
Copy link

I've made the modification described here. If there is interest I can open a PR for it.

@febeling
Copy link
Owner

Yes, still open to this @Zanderwohl.

@febeling febeling reopened this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@febeling @cmyr @Zanderwohl