From f64f8ab9abb466314f62a5814ee72dc1f646644f Mon Sep 17 00:00:00 2001 From: Qijia Liu Date: Sun, 7 Jul 2024 00:29:46 -0400 Subject: [PATCH 1/2] don't silently fail when loading shared library --- src/lib/fcitx/addonloader.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/fcitx/addonloader.cpp b/src/lib/fcitx/addonloader.cpp index 5679a872a..4a8961a3b 100644 --- a/src/lib/fcitx/addonloader.cpp +++ b/src/lib/fcitx/addonloader.cpp @@ -45,6 +45,7 @@ AddonInstance *SharedLibraryLoader::load(const AddonInfo &info, info.uniqueName(), std::make_unique(std::move(lib))); } catch (const std::exception &e) { + FCITX_ERROR() << e.what(); } break; } From 75d092d26c8f6fde136ce63871cfc01bbbb0b599 Mon Sep 17 00:00:00 2001 From: Weng Xuetian Date: Fri, 12 Jul 2024 11:28:23 -0700 Subject: [PATCH 2/2] Update addonloader.cpp --- src/lib/fcitx/addonloader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/fcitx/addonloader.cpp b/src/lib/fcitx/addonloader.cpp index 4a8961a3b..efa9515ca 100644 --- a/src/lib/fcitx/addonloader.cpp +++ b/src/lib/fcitx/addonloader.cpp @@ -45,7 +45,8 @@ AddonInstance *SharedLibraryLoader::load(const AddonInfo &info, info.uniqueName(), std::make_unique(std::move(lib))); } catch (const std::exception &e) { - FCITX_ERROR() << e.what(); + FCITX_ERROR() << "Failed to initialize addon factory for addon " + << info.uniqueName() << ". Error: " << e.what(); } break; }