Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to Filter/Search stories #49

Closed
2 tasks done
fbuys opened this issue Jun 9, 2021 · 6 comments · Fixed by #168
Closed
2 tasks done

Add ability to Filter/Search stories #49

fbuys opened this issue Jun 9, 2021 · 6 comments · Fixed by #168
Labels
enhancement New feature or request Feature Request

Comments

@fbuys
Copy link
Contributor

fbuys commented Jun 9, 2021

IMPORTANT: please make sure you ask yourself all intro questions and fill all sections of the template.

  • I checked the documentation and didn't find this feature
  • I checked to make sure that this feature has not already been requested

Branch/Commit:

main

Describe the feature:

Please include a detailed description of the feature you are requesting and any detail on it’s expected behavior.

As a estimator
I would like to look (or filter) for stories by name
And then I open a project type into a searchbox
And I see stories related to the input text

Problem:

Currently when a project grows it becomes harder and harder to find stories.
This could cause us to add duplicate stories when we cannot find an existing story.

Mockups:

TBD

Resources:

TBD

I will abide by the code of conduct

@fbuys fbuys added the enhancement New feature or request label Jun 9, 2021
@mateusdeap
Copy link
Member

I wonder, wouldn't this be an elaboration of #7? I can take a look into this. Maybe we can add labels and allow the search to go over both labels and descriptions?

@fbuys
Copy link
Contributor Author

fbuys commented Jun 10, 2021

Sounds good, I think any search ability would be good to start with. Then we can expand to labels etc.

@mateusdeap
Copy link
Member

So, I made a first implementation using ransack (which I've used many times in the past and I really like it). However, I would like some comments on the UI/UX side of things

image

I wonder how could this be made to be less horrible? Also, is there a guide anywhere for our css styles or something?

@mateusdeap
Copy link
Member

I was able to make it a bit better:
image

@fbuys
Copy link
Contributor Author

fbuys commented Jun 11, 2021

Hey @mateusdeap, nice progress 👍

I think it can be slimmed down a bit, it is taking up quite a bit of vertical space at the moment.
I am not sure we need a search button, we could debounce keyDown and search as the user types perhaps?

Slimmed down ideas:
image
image

@mateusdeap
Copy link
Member

@buys-fran checkout the feature/filter-stories branch. It has what I worked on until now. I only have 2 comments for the time being:

  • Tests are still missing. I intend to add them later
  • Despite the fact that it works pretty well, I believe, I think some further modifications will be needed, like extracting a template or some such, to be rendered using a js.erb file. The reason is that every form submission unfocuses the input field used to filter the stories. This means that after it updates the list, we need to click the input field again in order to change the search terms. It's somewhat annoying, in my opinion...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants