diff --git a/src/Services/Webhooks/Webhooks.API/Infrastructure/HttpGlobalExceptionFilter.cs b/src/Services/Webhooks/Webhooks.API/Infrastructure/HttpGlobalExceptionFilter.cs index a1ebf5c4c..39eab9908 100644 --- a/src/Services/Webhooks/Webhooks.API/Infrastructure/HttpGlobalExceptionFilter.cs +++ b/src/Services/Webhooks/Webhooks.API/Infrastructure/HttpGlobalExceptionFilter.cs @@ -2,18 +2,18 @@ public class HttpGlobalExceptionFilter : IExceptionFilter { - private readonly IWebHostEnvironment env; - private readonly ILogger logger; + private readonly IWebHostEnvironment _env; + private readonly ILogger _logger; public HttpGlobalExceptionFilter(IWebHostEnvironment env, ILogger logger) { - this.env = env; - this.logger = logger; + _env = env; + _logger = logger; } public void OnException(ExceptionContext context) { - logger.LogError(new EventId(context.Exception.HResult), + _logger.LogError(new EventId(context.Exception.HResult), context.Exception, context.Exception.Message); @@ -26,7 +26,7 @@ public void OnException(ExceptionContext context) Detail = "Please refer to the errors property for additional details." }; - problemDetails.Errors.Add("DomainValidations", new string[] { context.Exception.Message.ToString() }); + problemDetails.Errors.Add("DomainValidations", new [] { context.Exception.Message }); context.Result = new BadRequestObjectResult(problemDetails); context.HttpContext.Response.StatusCode = (int)HttpStatusCode.BadRequest; @@ -35,12 +35,12 @@ public void OnException(ExceptionContext context) { var json = new JsonErrorResponse { - Messages = new[] { "An error ocurred." } + Messages = new[] { "An error occurred." } }; - if (env.IsDevelopment()) + if (_env.IsDevelopment()) { - json.DeveloperMeesage = context.Exception; + json.DeveloperMessage = context.Exception; } context.Result = new InternalServerErrorObjectResult(json); @@ -53,6 +53,6 @@ private class JsonErrorResponse { public string[] Messages { get; set; } - public object DeveloperMeesage { get; set; } + public object DeveloperMessage { get; set; } } } diff --git a/src/Services/Webhooks/Webhooks.API/Services/GrantUrlTesterService.cs b/src/Services/Webhooks/Webhooks.API/Services/GrantUrlTesterService.cs index ea75ac343..9f480ddc3 100644 --- a/src/Services/Webhooks/Webhooks.API/Services/GrantUrlTesterService.cs +++ b/src/Services/Webhooks/Webhooks.API/Services/GrantUrlTesterService.cs @@ -45,6 +45,6 @@ private bool CheckSameOrigin(string urlHook, string url) return firstUrl.Scheme == secondUrl.Scheme && firstUrl.Port == secondUrl.Port && - firstUrl.Host == firstUrl.Host; + firstUrl.Host == secondUrl.Host; } } diff --git a/src/Services/Webhooks/Webhooks.API/Services/IdentityService.cs b/src/Services/Webhooks/Webhooks.API/Services/IdentityService.cs index cd821dc74..6b7c580f8 100644 --- a/src/Services/Webhooks/Webhooks.API/Services/IdentityService.cs +++ b/src/Services/Webhooks/Webhooks.API/Services/IdentityService.cs @@ -2,7 +2,7 @@ public class IdentityService : IIdentityService { - private IHttpContextAccessor _context; + private readonly IHttpContextAccessor _context; public IdentityService(IHttpContextAccessor context) { diff --git a/src/Services/Webhooks/Webhooks.API/Startup.cs b/src/Services/Webhooks/Webhooks.API/Startup.cs index 256941efa..07325bcbc 100644 --- a/src/Services/Webhooks/Webhooks.API/Startup.cs +++ b/src/Services/Webhooks/Webhooks.API/Startup.cs @@ -88,7 +88,7 @@ protected virtual void ConfigureEventBus(IApplicationBuilder app) } } -static class CustomExtensionMethods +internal static class CustomExtensionMethods { public static IServiceCollection AddAppInsight(this IServiceCollection services, IConfiguration configuration) { @@ -171,53 +171,50 @@ public static IServiceCollection AddSwagger(this IServiceCollection services, IC public static IServiceCollection AddEventBus(this IServiceCollection services, IConfiguration configuration) { if (configuration.GetValue("AzureServiceBusEnabled")) + { + services.AddSingleton(sp => { - services.AddSingleton(sp => - { - var serviceBusPersisterConnection = sp.GetRequiredService(); - var iLifetimeScope = sp.GetRequiredService(); - var logger = sp.GetRequiredService>(); - var eventBusSubcriptionsManager = sp.GetRequiredService(); - string subscriptionName = configuration["SubscriptionClientName"]; - - return new EventBusServiceBus(serviceBusPersisterConnection, logger, - eventBusSubcriptionsManager, iLifetimeScope, subscriptionName); - }); + var serviceBusPersisterConnection = sp.GetRequiredService(); + var iLifetimeScope = sp.GetRequiredService(); + var logger = sp.GetRequiredService>(); + var eventBusSubscriptionManager = sp.GetRequiredService(); + string subscriptionName = configuration["SubscriptionClientName"]; + + return new EventBusServiceBus(serviceBusPersisterConnection, logger, + eventBusSubscriptionManager, iLifetimeScope, subscriptionName); + }); - } - else + } + else + { + services.AddSingleton(sp => { - services.AddSingleton(sp => + var subscriptionClientName = configuration["SubscriptionClientName"]; + var rabbitMQPersistentConnection = sp.GetRequiredService(); + var iLifetimeScope = sp.GetRequiredService(); + var logger = sp.GetRequiredService>(); + var eventBusSubscriptionManager = sp.GetRequiredService(); + + var retryCount = 5; + if (!string.IsNullOrEmpty(configuration["EventBusRetryCount"])) { - var subscriptionClientName = configuration["SubscriptionClientName"]; - var rabbitMQPersistentConnection = sp.GetRequiredService(); - var iLifetimeScope = sp.GetRequiredService(); - var logger = sp.GetRequiredService>(); - var eventBusSubcriptionsManager = sp.GetRequiredService(); - - var retryCount = 5; - if (!string.IsNullOrEmpty(configuration["EventBusRetryCount"])) - { - retryCount = int.Parse(configuration["EventBusRetryCount"]); - } + retryCount = int.Parse(configuration["EventBusRetryCount"]); + } - return new EventBusRabbitMQ(rabbitMQPersistentConnection, logger, iLifetimeScope, eventBusSubcriptionsManager, subscriptionClientName, retryCount); - }); - } + return new EventBusRabbitMQ(rabbitMQPersistentConnection, logger, iLifetimeScope, eventBusSubscriptionManager, subscriptionClientName, retryCount); + }); + } - services.AddSingleton(); - services.AddTransient(); - services.AddTransient(); - services.AddTransient(); + services.AddSingleton(); + services.AddTransient(); + services.AddTransient(); + services.AddTransient(); - return services; + return services; } public static IServiceCollection AddCustomHealthCheck(this IServiceCollection services, IConfiguration configuration) { - var accountName = configuration.GetValue("AzureStorageAccountName"); - var accountKey = configuration.GetValue("AzureStorageAccountKey"); - var hcBuilder = services.AddHealthChecks(); hcBuilder