Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: Recursive Protobuf Serialization/Deserialization #37

Open
farbodahm opened this issue Sep 24, 2024 · 0 comments
Open

Optimization: Recursive Protobuf Serialization/Deserialization #37

farbodahm opened this issue Sep 24, 2024 · 0 comments
Labels
optimization Good enginges should be optimized all the time!

Comments

@farbodahm
Copy link
Owner

In the PR #35, I introduced a recursive way for serializing/deserializing Records to Protobuf messages (while adding ArrayTypes).

It's also possible to rewrite that functionality without recursion (while assuming ArrayType only contains one type).
For the sake of simplicity, For now I keep that functionality. But we need to benchmark, verify and make sure that it's not creating a performance overhead for our engine.

@farbodahm farbodahm added the optimization Good enginges should be optimized all the time! label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Good enginges should be optimized all the time!
Projects
None yet
Development

No branches or pull requests

1 participant