Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes for spaCy universe approval #1

Open
2 tasks
fako opened this issue Jun 17, 2018 · 0 comments
Open
2 tasks

Make changes for spaCy universe approval #1

fako opened this issue Jun 17, 2018 · 0 comments

Comments

@fako
Copy link
Owner

fako commented Jun 17, 2018

There are a few things pointed out in spaCy documentation that would reject this package in their universe.

  • remove "spacy" from the module name attribute
  • except an "attrs" property on init to allow override of the "arguments" attribute name

More details are at this link: https://spacy.io/usage/processing-pipelines#extensions

When this is done also add an entry to the spaCy universe repo to get included: https://github.com/explosion/spacy/blob/master/website/universe/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant