You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Token caching is implemented in faculty.session.get_session. But this calls faculty.config.resolve_profile which has a pre-defined order of places it pulls credentials from. It would be better if faculty.session.get_session takes in a faculty.config.Profile instance (or caching is implemented without having to always force resolving profiles). For example, on a platform server that has environmental variables defined, passing credentials_path to faculty.session.get_session has no effect.
Note that for my example there is a somewhat ugly workaround:
Yeah, this is probably a better interface, as it allows more flexibility in constructing a session for a profile. I like the decoupling of loading profile from building the session. This would be an API-breaking change, which I feel is probably ok here as this interface is not frequently used.
Token caching is implemented in
faculty.session.get_session
. But this callsfaculty.config.resolve_profile
which has a pre-defined order of places it pulls credentials from. It would be better iffaculty.session.get_session
takes in afaculty.config.Profile
instance (or caching is implemented without having to always force resolving profiles). For example, on a platform server that has environmental variables defined, passingcredentials_path
tofaculty.session.get_session
has no effect.Note that for my example there is a somewhat ugly workaround:
The text was updated successfully, but these errors were encountered: