Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate testing of example Jupyter notebooks #450

Open
ChrisCummins opened this issue Oct 5, 2021 · 0 comments · May be fixed by #454
Open

Automate testing of example Jupyter notebooks #450

ChrisCummins opened this issue Oct 5, 2021 · 0 comments · May be fixed by #454
Assignees
@ChrisCummins
Labels
Enhancement New feature or request Testing & Tooling Tests, tooling, and build systems
Milestone
v0.2.7

Comments

@ChrisCummins
Copy link
Contributor

🚀 Feature

This repo contains Jupyter notebooks to demonstrate CompilerGym's features. These notebooks are not currently tested as part of a CI job so they can easily bitrot.

Motivation

I <3 regression testing.

Pitch

Use pytest + nbmake to test Jupyter notebooks and integrate that into the make test and make install-test targets.

Alternatives

Probably many, this was the first solution that Google found for me.
@ChrisCummins ChrisCummins added Enhancement New feature or request Testing & Tooling Tests, tooling, and build systems labels Oct 5, 2021
@ChrisCummins ChrisCummins added this to the v0.2.1 milestone Oct 5, 2021
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Oct 6, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
d3148c2 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
@ChrisCummins ChrisCummins linked a pull request Oct 6, 2021 that will close this issue
Open
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Oct 6, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
e4a94f5 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Oct 11, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
dcc67eb 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
@ChrisCummins ChrisCummins self-assigned this Oct 11, 2021
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Oct 12, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
d133977 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Nov 5, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
b0d5d8e 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
@ChrisCummins ChrisCummins modified the milestones: v0.2.1, v0.2.2 Nov 17, 2021
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Dec 14, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
478e70c 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Dec 14, 2021
@ChrisCummins
[tests] Automate Jupyter notebook tests using nbmake.
3cfbb47 
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
@ChrisCummins ChrisCummins modified the milestones: v0.2.2, v0.2.3 Jan 19, 2022
@ChrisCummins ChrisCummins modified the milestones: v0.2.3, v0.2.4 Mar 18, 2022
@ChrisCummins ChrisCummins modified the milestones: v0.2.4, v0.2.5 May 24, 2022
@ChrisCummins ChrisCummins modified the milestones: v0.2.5, v0.2.6, v0.2.7 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisCummins ChrisCummins

Labels
Enhancement New feature or request Testing & Tooling Tests, tooling, and build systems
Projects
None yet
Milestone
v0.2.7
Development

Successfully merging a pull request may close this issue.

[tests] Automate Jupyter notebook tests using nbmake. ChrisCummins/CompilerGym
1 participant
@ChrisCummins