Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pytx][mlh] Convert some tests in threatexchange/signal_type/ to py.test #1686

Closed
Dcallies opened this issue Nov 8, 2024 · 1 comment · Fixed by #1742 · May be fixed by #1693
Closed

[pytx][mlh] Convert some tests in threatexchange/signal_type/ to py.test #1686

Dcallies opened this issue Nov 8, 2024 · 1 comment · Fixed by #1742 · May be fixed by #1693
Labels
mlh Related to Major League Hacking Fellowship

Comments

@Dcallies
Copy link
Contributor

Dcallies commented Nov 8, 2024

https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/tests/test_hash_from_x.py
https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/tests/test_md5_hash.py
https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/tests/test_pdq_index.py
https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/tests/test_raw_text.py
https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/tests/test_url_md5_hash.py

These tests are using unittest, we want to use py.test.

py.test docs: https://docs.pytest.org/en/stable/
@Dcallies Dcallies added the mlh Related to Major League Hacking Fellowship label Nov 8, 2024
@Dcallies Dcallies changed the title [pytx][mlh] Convert some tests in threatexchange/signal_type/ to pytx [pytx][mlh] Convert some tests in threatexchange/signal_type/ to py.test Nov 8, 2024
@ZeyadTarekk
Copy link
Contributor

I will work on that

@ZeyadTarekk ZeyadTarekk mentioned this issue Nov 8, 2024
Open
b8zhong added a commit to b8zhong/ThreatExchange that referenced this issue Jan 31, 2025
@b8zhong
feat: unittest => pytest conversion (#facebook#1686)
448580b 
Previous tests in `signal_type` were converted to pytest
@b8zhong b8zhong mentioned this issue Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mlh Related to Major League Hacking Fellowship
Projects
None yet
Milestone
No milestone
2 participants
@Dcallies @ZeyadTarekk