uncaught promise rejection for /:book/users when entering an invalid book

[rooberrydev]

week7-hihi/handlers/users-handler.js

Lines 60 to 77 in 68325ba

	booksModel
	.getIdFromTitle(book)
	.then((bookInfo) => {
	const bookId = bookInfo.rows[0].id
	junctionModel
	.getUserFromBook(bookId)
	.then((userInfo) => {
	const userIds = userInfo.rows.map(obj => obj.user_id)
	usersModel
	.getMultipleUsersById(userIds)
	.then((userList) => {
	const users = userList.rows.map(e => e.username);
	console.log(users);
	res.status(200).send(users)
	})
	})
	.catch(next)
	})

again, hard to keep track of due to nested brackets, but its a case of a missing .catch()

you're catching junctionModel.getUserFromBook, but before that there's booksModel.getIdFromTitle which will throw an exception when theres an error.

adding .catch(next) on line 77 should do the trick.

btw, absolutely brilliant naming for your model functions!

[jackherizsmith]

do all queries need catches?

[rooberrydev]

@jackherizsmith Ideally you should have a catch somewhere in the chain. If the db query returns a resolved/rejected promise to somewhere else, you can put the catch there(in the handler) to make the error handling a server response.
So queries themselves can be left without cstches, just return the promise in its final state, and then you can propagate all errors up to the handler level and .catch() there