New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easy to follow setup instructions! good job! 👌 #30

Open

rooberrydev opened this issue Apr 17, 2020 · 0 comments

Labels

code review compliment documentation

rooberrydev commented Apr 17, 2020

just a few notes to improve this,

your instructions say create a test db called readers_coders_test_db but package.json has readers_test_db.
commenting out the connectionString part of the new pg.Pool() call isn't actually necessary, since locally process.env.DATABASE_URL wouldn't exist(it's undefined), and pg will ignore that and use the local PG_DATABASE PG_USER PG_PASSWORD variables.

rooberrydev added compliment documentation labels

hannahgooding added the code review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment