Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react 16.8? #49

Open
dante-blitz opened this issue May 9, 2019 · 8 comments
Open

Update to react 16.8? #49

dante-blitz opened this issue May 9, 2019 · 8 comments
Labels
needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting.

Comments

@dante-blitz
Copy link

Hi there,

Thanks for your great starter.

Do you have any plans to update react to 16.8? I'm keen to experiment using material-ui v4 with your starter but it requires 16.8. I tried updating packages myself but they broke everything.

@fabe
Copy link
Owner

fabe commented May 9, 2019

Hey @dante-blitz, you should be able to update React by running yarn add react react-dom. I also updated it on the master branch now. If it still doesn't work, delete the node_modules folder and reinstall the dependencies again with yarn install.

@dante-blitz
Copy link
Author

dante-blitz commented May 9, 2019

Thank for the info @fabe.

I just tried to update again. Here are the steps I took after cloning this repo:

  1. yarn add react-dom
  2. yarn develop

I get the following error message:

Error: Failed to process image ...content/images/gallery/react-context.jpg

@fabe
Copy link
Owner

fabe commented May 9, 2019

Did it work before you updated? And did you update both react and react-dom?

@dante-blitz
Copy link
Author

Actually it doesn't work before the update. same issue.

@dante-blitz
Copy link
Author

Running on Windows 10.

@dante-blitz
Copy link
Author

dante-blitz commented May 9, 2019

Here is the full error message:

error UNHANDLED REJECTION

Error: Failed to process image .../content/images/gallery/react-context.jpg

(sharp:1391): GLib-CRITICAL **: 17:30:36.920: g_hash_table_lookup: assertion 'hash_table != NULL' failed
(sharp:1391): GLib-CRITICAL **: 17:30:37.427: g_hash_table_lookup: assertion 'hash_table != NULL' failed
(sharp:1391): GLib-CRITICAL **: 17:30:37.779: g_hash_table_lookup: assertion 'hash_table != NULL' failed
error Command failed with exit code 1.

@fabe
Copy link
Owner

fabe commented May 9, 2019

Difficult to debug from here, but I'm pretty sure this is not an issue with this starter itself. There's a similar issue that suggests you to update yarn (either by curl --compressed -o- -L https://yarnpkg.com/install.sh | bash or brew upgrade yarn). Maybe try that, together with removing the yarn.lock.

Alternatively, you can try reinstalling everything with npm install.

@dante-blitz
Copy link
Author

tried. all options you suggested but the issue still persists.

I'll explore the issue myself and see if I can get to the bottom of it.

@fabe fabe added the needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting.
Projects
None yet
Development

No branches or pull requests

2 participants