Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context_t::flags() should not be virtual #706

Open
eyalroz opened this issue Jan 26, 2025 · 0 comments
Open

context_t::flags() should not be virtual #706

eyalroz opened this issue Jan 26, 2025 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 26, 2025

For some reason, context_t::flags() is marked as virtual, even though primary_context_t does not override it, and there are no other subclasses. That's a mistake.
@eyalroz eyalroz added the task label Jan 26, 2025
@eyalroz eyalroz self-assigned this Jan 26, 2025
eyalroz pushed a commit that referenced this issue Jan 26, 2025
@eyalroz-gehc
Fixed #706, regards #704: context_t::flags() is no longer gratuitou…
07d12c5 
…sly marked `virtual`
@eyalroz eyalroz reopened this Jan 26, 2025
eyalroz pushed a commit that referenced this issue Jan 26, 2025
@eyalroz-gehc @eyalroz
Fixed #706, regards #704: context_t::flags() is no longer gratuitou…
eb18b32 
…sly marked `virtual`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz