Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to define a Services variable #129

Open
eyalroz opened this issue Jul 29, 2024 · 0 comments
Open

No need to define a Services variable #129

eyalroz opened this issue Jul 29, 2024 · 0 comments
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jul 29, 2024 •
edited
Loading

At some point (after TB 115?), it became unnecessary to define a Services global - it's already defined for us. So let's drop the:

var Services = globalThis.Services;

and similar definitions.
@eyalroz eyalroz added the task label Jul 29, 2024
eyalroz added a commit that referenced this issue Jul 29, 2024
@eyalroz
Fixes #129: Not defining Services anymore, it's automatically defin…
963fd0b 
…ed globally with recent TB versions
eyalroz added a commit that referenced this issue Jul 29, 2024
@eyalroz
Fixes #129: Not defining Services anymore, it's automatically defin…
4f8d392 
…ed globally with recent TB versions
eyalroz added a commit that referenced this issue Nov 4, 2024
@eyalroz
Fixes #129: Not defining Services anymore, it's automatically defin…
3b769ba 
…ed globally with recent TB versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz