-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkSyntax function that doesn't write to a file #295
Comments
I did a bit of performance analysis:
result stays around 120 ms
result started at 100ms then went down to a consistent 20ms
was also around 20ms |
Another reason this would be a good change is windows doesn't clear the temp directory by default, so temporary syntax-checked python files will keep on piling up forever. |
I would like to work on this issue, however I am new to contributing to Python Shell. Is there anywhere I can go to sign up for write access to non-master branches? |
@PlakxD I'm not the admin of this repo, so I can't give out write access, but you can fork the repo and then submit a PR. |
Is your feature request related to a problem? Please describe.
If I call checkSyntax very frequently I'm going be writing a ton of temp files. Would be nice to avoid that overhead and just feed in the string through stdin.
Describe the solution you'd like
checkSyntax using stdin
Describe alternatives you've considered
overhead might not be a big deal?
Additional context
Related to re-architecture work in Almenon/AREPL-vscode#439. I'd like to throw away pythonGuiLibraryIsPresent and just check syntax all the time. Less code needed and much less hacky because one doesn't have to list out each GUI library.
The text was updated successfully, but these errors were encountered: