Resend order mails

[slowhand11]

it would be nice to have the possibility to resend the order mail to customer.
A customer deleted his mail and asks me to resend.

[rintisch]

As far as I can see is this not easy to integrate at the moment.
The process looks as follows:
During the order the FinishEvent is dispatched:

cart/Classes/Controller/Cart/OrderController.php

Line 234 in cb2a245

$finishEvent = new FinishEvent($this->cart, $orderItem, $this->configurations);

This triggers the EventListener Order/Finish/Email.php:

cart/Classes/EventListener/Order/Finish/Email.php

Lines 23 to 27 in cb2a245

	public function __invoke(FinishEvent $event): void
	{
	$this->cart = $event->getCart();
	$orderItem = $event->getOrderItem();
	$settings = $event->getSettings();

... which executes sendBuyerMail():

cart/Classes/EventListener/Order/Finish/Email.php

Lines 49 to 56 in cb2a245

	protected function sendBuyerMail(Item $orderItem): void
	{
	$mailHandler = GeneralUtility::makeInstance(
	MailHandler::class
	);
	$mailHandler->setCart($this->cart);
	$mailHandler->sendBuyerMail($orderItem);
	}

... which is using the MailHandler's method sendBuyerMail():

cart/Classes/Service/MailHandler.php

Lines 292 to 310 in cb2a245

	public function sendBuyerMail(Item $orderItem): void
	{
	if (empty($this->getBuyerEmailFrom()) || empty($orderItem->getBillingAddress()->getEmail())) {
	return;
	}
	$status = $orderItem->getPayment()->getStatus();
	$fromAddress = new Address($this->getBuyerEmailFrom(), $this->getBuyerEmailName());
	$email = new FluidEmail();
	$email
	->to($orderItem->getBillingAddress()->getEmail())
	->from($fromAddress)
	->setTemplate('Mail/' . ucfirst($status) . '/Buyer')
	->format(FluidEmail::FORMAT_HTML)
	->assign('settings', $this->pluginSettings['settings'])
	->assign('cart', $this->cart)
	->assign('orderItem', $orderItem);

As the referenced lines show needs the MailHandler the cart object. But this does no longer exist because it does not get stored. I cannot see how this could be solved.

The scope to refactor this seems quite big and no other seemed to miss the feature. I would propose to close this issue.
@extcode do you agree?

[rintisch]

But a question I got: Why is the cart not stored?

[extcode]

Why we should store the cart (session) to the database? Perhaps one can do this with an own Event. There is an model for storing the cart to database, but this is intended to store the cart while the customer was redirected a payment provider. In error case the cart can be restored from there.

I it should be possible to add a button (to the backend) which directly instantiate the MailHandler or trigger an event. I think the MailHandler can be used for that process, because $this->cart isn't a hard requirement. It is not an constructor argument, but will be set by $mailHandler->setCart($cart). It's then only assigned to the view (FluidEmail). So if the email template do not use/require any information from the cart session, you will be save.

You may also want to have a separate template for the resend that contains different wording and makes it clear that it is a resend of the email and not a new order. This could probably also be solved.

[rintisch]

I just realized that there are two Cart:

• https://github.com/extcode/cart/blob/main/Classes/Domain/Model/Cart.php
• https://github.com/extcode/cart/blob/main/Classes/Domain/Model/Cart/Cart.php

The first is the one which could be stored by a payment provider. But the second is needed. And it is really needed because it stores the currency (cart.currency) and the summary data (cart.net, cart.gross, ...) of the order. This is heavily used in the email template, e.g. here:

cart/Resources/Private/Partials/Mail/CartSummary.html

Line 17 in cb2a245

<cart:format.currency currencySign="{cart.currencySign}">{cart.net}</cart:format.currency>

[rintisch]

Follow-up: It is possible to solve this. Maybe the email-templates should even be cleaned up (not sure). Because: All those information are stored in the table tx_cart_domain_model_order_item.

These information are persisted, this is used in the backend:

cart/Resources/Private/Partials/Backend/Order/Show/CartTable/Footer.html

Line 10 in cb2a245

<cart:format.currency currencySign="{orderItem.currency}">{orderItem.net}</cart:format.currency>

... and imo should anyway also be used in the emails!?

[extcode]

Yes. I think we can try to get rid of properties of the cart object in email templates. Most should be easily replaceable.