Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple recipient with one push message #52

Open
mbordia-eightfold opened this issue Dec 25, 2022 · 1 comment
Open

Comments

@mbordia-eightfold
Copy link

As per this example in expo documentation to attribute in PushMessage should expect string[] as well allowing support for multiple recipient for a push message.

There are few places in the codebase which results in the error when we pass list of expo tokens in to attribute:

  1. Expects to attribute to be string only
  2. Throws error even if response is expected response

I think proper implementation for this would either require :
a. removal of the assumption that 1 push message corresponds to single recipient
b. or converting single PushMessage into multiple duplicate PushMessages.

@julianpacker
Copy link
Collaborator

Good point. I never noticed that. I think doing a is the ideal solution, seems more efficient. Let me review that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants